the ride looks good but I would clear that leather from the grip area you don't want to be grabbing leather. Also end the stitching at the trigger guard about 1/4" lower back stitch it just a bit , the stitching at the round of the trigger guard I would get it closer and at the muzzle end I would get the stitching closer to the frame.
that's all if this is a holster to carry . If it's just something to put the gun in then that's not a problem. All that said you did a clean job . And this is all just my opinion not meant in any way to criticize.